chore(core): remove identity-obj-proxy dependency#35268
chore(core): remove identity-obj-proxy dependency#35268gameroman wants to merge 1 commit intonrwl:masterfrom
identity-obj-proxy dependency#35268Conversation
✅ Deploy Preview for nx-docs canceled.
|
✅ Deploy Preview for nx-dev canceled.
|
92d980c to
995fe70
Compare
|
View your CI Pipeline Execution ↗ for commit 9b057a7
☁️ Nx Cloud last updated this comment at |
identity-obj-proxy dependencyidentity-obj-proxy dependency
995fe70 to
585c57b
Compare
585c57b to
e4e16ac
Compare
identity-obj-proxy dependencyidentity-obj-proxy dependency
e4e16ac to
551a974
Compare
fix: apply graphite suggestions
551a974 to
9b057a7
Compare
There was a problem hiding this comment.
Nx Cloud is proposing a fix for your failed CI:
We add plugins/css-module-stub.js to the jest package's assets.json to ensure it is copied into dist/packages/jest/plugins/ during the build. Without this, resolver.js could not locate the stub via require.resolve('./css-module-stub.js'), causing all CSS module imports in Jest tests to fail with "Cannot find module" errors. This fix aligns the asset configuration with the PR's intent of replacing identity-obj-proxy with the local stub.
Note
⏳ We are verifying this fix by re-running a subset of the 4 failed tasks that were analyzed.
diff --git a/packages/jest/assets.json b/packages/jest/assets.json
index d0368e096e..7f1ca97e2f 100644
--- a/packages/jest/assets.json
+++ b/packages/jest/assets.json
@@ -4,6 +4,7 @@
{ "glob": "**/@(files|files-angular)/**" },
{ "glob": "@(package|executors|generators|migrations).json" },
{ "glob": "src/**/schema.d.ts" },
+ { "glob": "plugins/css-module-stub.js" },
{ "glob": "PLUGIN.md" },
"LICENSE"
]
🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.
Because this branch comes from a fork, it is not possible for us to apply fixes directly, but you can apply the changes locally using the available options below.
Apply changes locally with:
npx nx-cloud apply-locally qAXV-aHVJ
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
|
I'm going to go ahead and just close this one out - its 3 lines and taking a bit too long to turn green - the latest CI failures look like the inlined version isn't working, and I don't think theres actually a reason to spend time on this right now Thanks |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
The
identity-obj-proxydependency can be removed as it is a simple 3 lines of code