Skip to content

chore(core): remove identity-obj-proxy dependency#35268

Closed
gameroman wants to merge 1 commit intonrwl:masterfrom
gameroman:remove-identity-obj-proxy-dependency
Closed

chore(core): remove identity-obj-proxy dependency#35268
gameroman wants to merge 1 commit intonrwl:masterfrom
gameroman:remove-identity-obj-proxy-dependency

Conversation

@gameroman
Copy link
Copy Markdown

@gameroman gameroman commented Apr 12, 2026

The identity-obj-proxy dependency can be removed as it is a simple 3 lines of code

@gameroman gameroman requested a review from a team as a code owner April 12, 2026 18:14
@gameroman gameroman requested a review from AgentEnder April 12, 2026 18:14
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 12, 2026

Deploy Preview for nx-docs canceled.

Name Link
🔨 Latest commit e4e16ac
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/69e191e7fe61180008913306

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 12, 2026

Deploy Preview for nx-dev canceled.

Name Link
🔨 Latest commit e4e16ac
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/69e191e7dd0c970008f3c50e

Comment thread scripts/patched-jest-resolver.js Outdated
@gameroman gameroman force-pushed the remove-identity-obj-proxy-dependency branch from 92d980c to 995fe70 Compare April 15, 2026 19:18
@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Apr 15, 2026

View your CI Pipeline Execution ↗ for commit 9b057a7

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ❌ Failed 45m 51s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 3s View ↗
nx-cloud record -- pnpm nx-cloud conformance:check ✅ Succeeded 18s View ↗
nx build workspace-plugin ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 24s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 14s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-20 19:19:26 UTC

@gameroman gameroman changed the title chore: remove identity-obj-proxy dependency chore(deps): remove identity-obj-proxy dependency Apr 15, 2026
@gameroman gameroman force-pushed the remove-identity-obj-proxy-dependency branch from 995fe70 to 585c57b Compare April 16, 2026 11:58
@AgentEnder AgentEnder force-pushed the remove-identity-obj-proxy-dependency branch from 585c57b to e4e16ac Compare April 17, 2026 01:50
@AgentEnder AgentEnder changed the title chore(deps): remove identity-obj-proxy dependency chore(core): remove identity-obj-proxy dependency Apr 17, 2026
@AgentEnder AgentEnder force-pushed the remove-identity-obj-proxy-dependency branch from e4e16ac to 551a974 Compare April 17, 2026 17:22
@AgentEnder AgentEnder force-pushed the remove-identity-obj-proxy-dependency branch from 551a974 to 9b057a7 Compare April 20, 2026 17:55
Copy link
Copy Markdown
Contributor

@nx-cloud nx-cloud Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud is proposing a fix for your failed CI:

We add plugins/css-module-stub.js to the jest package's assets.json to ensure it is copied into dist/packages/jest/plugins/ during the build. Without this, resolver.js could not locate the stub via require.resolve('./css-module-stub.js'), causing all CSS module imports in Jest tests to fail with "Cannot find module" errors. This fix aligns the asset configuration with the PR's intent of replacing identity-obj-proxy with the local stub.

Note

We are verifying this fix by re-running a subset of the 4 failed tasks that were analyzed.

diff --git a/packages/jest/assets.json b/packages/jest/assets.json
index d0368e096e..7f1ca97e2f 100644
--- a/packages/jest/assets.json
+++ b/packages/jest/assets.json
@@ -4,6 +4,7 @@
     { "glob": "**/@(files|files-angular)/**" },
     { "glob": "@(package|executors|generators|migrations).json" },
     { "glob": "src/**/schema.d.ts" },
+    { "glob": "plugins/css-module-stub.js" },
     { "glob": "PLUGIN.md" },
     "LICENSE"
   ]

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.

Because this branch comes from a fork, it is not possible for us to apply fixes directly, but you can apply the changes locally using the available options below.

Apply changes locally with:

npx nx-cloud apply-locally qAXV-aHVJ

Apply fix locally with your editor ↗   View interactive diff ↗



🎓 Learn more about Self-Healing CI on nx.dev

@AgentEnder
Copy link
Copy Markdown
Member

I'm going to go ahead and just close this one out - its 3 lines and taking a bit too long to turn green - the latest CI failures look like the inlined version isn't working, and I don't think theres actually a reason to spend time on this right now

Thanks

@AgentEnder AgentEnder closed this Apr 20, 2026
@gameroman gameroman deleted the remove-identity-obj-proxy-dependency branch April 20, 2026 19:16
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants